• Adam Klein's avatar
    Revert "[builtins][x64] Use callee-saved registers for write barrier stubs" · d23d68fe
    Adam Klein authored
    This reverts commit 17915002.
    
    Reason for revert: Breaks TSAN builds (e.g. https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20builder/19166/overview)
    
    Original change's description:
    > [builtins][x64] Use callee-saved registers for write barrier stubs
    >
    > Calls to the record write stub are quite frequent and the caller has to
    > save all registers used by the builtin.
    >
    > This CL moves the register saving to the builtin itself, reducing the
    > call-site code size significantly in many cases and thus improving
    > compilation speed of sparkplug.
    >
    > Follow-up CLs with introduce the same behaviour to other platforms.
    >
    > - CallRecordWriteStubSaveRegisters preserves the existing behaviour and
    >   saves clobbered registers.
    > - CallRecordWriteStub expects the registers to match the ones specified
    >   in the WriteBarrierDescriptor for more compact code.
    >
    > Bug: v8:11420
    > Change-Id: Ib1260cf972712bb9ba879beacd34b06a7fa347f1
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2922103
    > Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org>
    > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#74831}
    
    Bug: v8:11420
    Change-Id: I20f239e64ec2834acd651341634974291992add5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2922316
    Auto-Submit: Adam Klein <adamk@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#74832}
    d23d68fe
builtins-x64.cc 174 KB