• Mathias Bynens's avatar
    Normalize casing of hexadecimal digits · 822be9b2
    Mathias Bynens authored
    This patch normalizes the casing of hexadecimal digits in escape
    sequences of the form `\xNN` and integer literals of the form
    `0xNNNN`.
    
    Previously, the V8 code base used an inconsistent mixture of uppercase
    and lowercase.
    
    Google’s C++ style guide uses uppercase in its examples:
    https://google.github.io/styleguide/cppguide.html#Non-ASCII_Characters
    
    Moreover, uppercase letters more clearly stand out from the lowercase
    `x` (or `u`) characters at the start, as well as lowercase letters
    elsewhere in strings.
    
    BUG=v8:7109
    TBR=marja@chromium.org,titzer@chromium.org,mtrofin@chromium.org,mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org,mlippautz@chromium.org
    NOPRESUBMIT=true
    
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
    Change-Id: I790e21c25d96ad5d95c8229724eb45d2aa9e22d6
    Reviewed-on: https://chromium-review.googlesource.com/804294
    Commit-Queue: Mathias Bynens <mathias@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49810}
    822be9b2
functional.cc 2.64 KB