• Michael Achenbach's avatar
    Revert "Reland "[cpu-profiler] Fix stack iterability for fast C calls with no exit frame"" · 76786104
    Michael Achenbach authored
    This reverts commit ddaa1f0a.
    
    Reason for revert:
    Still flaky on windows. Maybe reland and keep skipped on windows?
    https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win32%20-%20nosnap%20-%20shared/31002
    https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/27826
    
    Original change's description:
    > Reland "[cpu-profiler] Fix stack iterability for fast C calls with no exit frame"
    > 
    > This is a reland of d5f4a33e
    > 
    > Original change's description:
    > > [cpu-profiler] Fix stack iterability for fast C calls with no exit frame
    > >
    > > Before fast C calls, store the current FP and PC on the isolate. When
    > > iterating frames in SafeStackFrameIterator, check if these fields are
    > > set and start iterating at the calling frame's FP instead of the current
    > > FP, which will be in C++ code. We need to do this because c_entry_fp is
    > > not set on the Isolate for Fast-C-Calls because we don't build an exit
    > > frame.
    > >
    > > This change makes stack samples that occur within 'Fast-C-Calls'
    > > iterable, meaning we can properly attribute ticks within the JS caller.
    > >
    > > Fast-C-Calls can't call back into JS code, so we can only ever have one
    > > such call on the stack at a time, allowing us to store the FP on the
    > > isolate rather than the stack.
    > >
    > > TBR=v8-mips-ports@googlegroups.com
    > >
    > > Bug: v8:8464, v8:7202
    > > Change-Id: I7bf39eba779dad34754d5759d741c421b362a406
    > > Reviewed-on: https://chromium-review.googlesource.com/c/1340241
    > > Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    > > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > > Reviewed-by: Martyn Capewell <martyn.capewell@arm.com>
    > > Reviewed-by: Alexei Filippov <alph@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#57896}
    > 
    > TBR=v8-mips-ports@googlegroups.com
    > TBR=jgruber@chromium.org
    > 
    > Bug: v8:8464, v8:7202
    > Change-Id: I5f37ded4ea572e8e9890ba186aa3d74a0dfc1274
    > Reviewed-on: https://chromium-review.googlesource.com/c/1354042
    > Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    > Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#57912}
    
    TBR=alph@chromium.org,jgruber@chromium.org,petermarshall@chromium.org,martyn.capewell@arm.com,v8-arm-ports@googlegroups.com,v8-mips-ports@googlegroups.com,ibogosavljevic@wavecomp.com
    
    Change-Id: If810648dbf60df2ff70455b6e8ef466136c90145
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:8464, v8:7202
    Reviewed-on: https://chromium-review.googlesource.com/c/1354461Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57925}
    76786104
macro-assembler-mips.cc 170 KB