• Clemens Backes's avatar
    Reland "[wasm] Provide a global WasmCodeManager" · 4e19455b
    Clemens Backes authored
    This is a reland of 0f90a2aa.
    The issue was inverted destructor order between WasmCodeManager and
    WasmEngine. WasmEngine has to be destructed first, because it contains
    a barrier to ensure that background compile threads finished before
    global state is being destructed.
    
    Original change's description:
    > [wasm] Provide a global WasmCodeManager
    >
    > The WasmCodeManager was part of the WasmEngine so far, but there is only
    > exactly one WasmEngine. Hence we can pull it out, and also remove the
    > pointer in the WasmCodeAllocator.
    >
    > The argument passed from the single constructor call is now inlined in
    > the constructor itself.
    >
    > Drive-by: Replace "GetPlatformPageAllocator()->CommitPageSize()" by just
    > "CommitPageSize()".
    >
    > R=jkummerow@chromium.org
    >
    > Bug: v8:11879
    > Change-Id: I6c0e74cea308f5806d1aa479945d90b6ef8d1613
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972909
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#75270}
    
    Bug: v8:11879
    Change-Id: I0eaa2395f5c1e30f3f7303c5f3df70c227b74d3d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2975859
    Auto-Submit: Clemens Backes <clemensb@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75289}
    4e19455b
wasm-engine.h 18.2 KB