• Maya Lekova's avatar
    Revert "[Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher" · 875480d2
    Maya Lekova authored
    This reverts commit 31228a69.
    
    Reason for revert: Introduces new pretty consistent flakes on Linux sanitizers, one of which block LKGR. Please see https://crbug.com/v8/8219
    
    Original change's description:
    > [Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher
    > 
    > Splits background compilation data out of ScriptStreamingData and into
    > BackgroundCompileTask. Also makes BackgroundCompileTask no longer a sub-class
    > of ScriptStreamingTask, and instead have ScriptStreamingTask delegate to a
    > BackgroundCompileTask.
    > 
    > As part of this change, we now create the CharacterStream on the main thread,
    > and therefore have to set the (thread-local) runtime_call_stats on the already
    > created CharacterStream when the BackgroundCompileTask is run on the background
    > thread. As such, changes to CharacterStream were needed to feed the
    > runtime_call_stats through appropriately.
    > 
    > Deprecates Source::GetCachedData and StreamedSource::GetCachedData since they are
    > no longer used, and the streamed source never has cached data (streaming is
    > suppressed if cached data is available). Also removes Utf8ChunkedStream which
    > is dead code.
    > 
    > BUG=v8:8041, v8:8015
    > TBR=yangguo@chromium.org
    > 
    > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
    > Change-Id: Ifcc723ebf930a1dc01135fcb70929d6168471cb3
    > Reviewed-on: https://chromium-review.googlesource.com/1236353
    > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#56182}
    
    TBR=rmcilroy@chromium.org,yangguo@chromium.org,verwaest@chromium.org
    
    Change-Id: Ib05bcbde2e9a588bd4008d2155f75cdac5cc47f5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:8041, v8:8015
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/1241958Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Commit-Queue: Maya Lekova <mslekova@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56187}
    875480d2
scanner-character-streams.cc 28.3 KB