-
Benedikt Meurer authored
For JSArrayBuffer instances (which map to both v8::ArrayBuffer and v8::SharedArrayBuffer), we add a couple of synthetic views to its ValueMirror to make it easy for developers to peak into the contents of the JSArrayBuffer. These were previously real properties, but that's just wrong (both intuitively and semantically), and they should instead be internal properties. Drive-by-fix: The [[IsDetached]] internal property should only be shown on actually detached JSArrayBuffer's to reduce visual clutter. And for detached JSArrayBuffers creating views on them throws TypeErrors per specification, so we shouldn't attempt to display views on them. Bug: v8:9308, chromium:1162229 Change-Id: Ia006de7873ca4b27aae7d00d46e1b69d2e326449 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2606047 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#71892}
2cab7ae9