• Jakob Gruber's avatar
    [compiler] Use kAssumeMemoryFence in two critical ref creation spots · 1e2b9c5e
    Jakob Gruber authored
    Using kAssumeMemoryFence works around the fact that the graph stores
    handles (and not refs). The assumption is that any handle inserted
    into the graph is safe to read; but we don't preserve the reason why
    it is safe to read. Thus we must over-approximate here and assume the
    existence of a memory fence.
    
    Note this is only valid if all spots that insert handles into the
    graph ensure that the handle can safely be read.
    
    In the future, we should consider having the graph store ObjectRefs or
    ObjectData pointer instead, which would make new ref construction here
    unnecessary.
    
    Bug: v8:7790,chromium:1209798
    Change-Id: Ic22340ea9f34a24be530a3c62c8309d25e108f3f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2902742Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74653}
    1e2b9c5e
types.cc 35.1 KB