• adamk's avatar
    Remove Scope::scope_contains_with_ bit · 108efd7f
    adamk authored
    This part of Scope has existed since V8's initial check in, but from what
    I can tell it's not required to implement "with". The only tests that
    depend upon it are tests of the debugger and the Scope mirrors, but the
    resulting test behavior after removing the bit still seems perfectly
    reasonable to me. In fact, with the included fix for scope name collection,
    the scope mirror is actually improved with this change.
    
    As a bi-product, this fixes the attached bug, about the contains_with
    bit having inconsistent values in some arrow function compilation
    scenarios.
    
    BUG=chromium:592353
    LOG=n
    CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
    
    Review URL: https://codereview.chromium.org/1804783002
    
    Cr-Commit-Position: refs/heads/master@{#34802}
    108efd7f
scopes.cc 50.4 KB