• Leszek Swirski's avatar
    [heap] Don't allocate fillers in sampling profiler · 7e181fb0
    Leszek Swirski authored
    Space::AllocationStep already allocates a filler object at the given
    address, so there's no need to do another filler object allocation in
    the sampling profiler. In addition, this breaks allocation stepping over
    areas that have already been initialized, such as off-thread pages being
    merged.
    
    Instead, we replace it with a DCHECK that there is a map at the start of
    the allocated chunk, which serves as a proxy for "this area is
    iteratable"
    
    Change-Id: Ia0a1375ac83b944cf5631e6bef341805d27b6e96
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2122029
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67230}
    7e181fb0
sampling-heap-profiler.cc 11.1 KB