• Santiago Aboy Solanes's avatar
    Revert "Reland "[compiler] Replace Symbol with direct reads"" · 47ea5fb6
    Santiago Aboy Solanes authored
    This reverts commit 7ce5dd6e.
    
    Reason for revert: Clusterfuzz saw an issue, which is an m87 blocker.
    Reverting and will re-assess & reland later.
    
    Bug: v8:7790, chromium:1137594
    
    Original change's description:
    > Reland "[compiler] Replace Symbol with direct reads"
    >
    > This is a reland of d3b295fa
    >
    > Got speculatively reverted in https://crrev.com/c/v8/v8/+/2403256 but
    > doesn't seem to have been causing the TSAN failures
    >
    > Original change's description:
    > > [compiler] Replace Symbol with direct reads
    > >
    > > Bug: v8:7790
    > > Change-Id: I49120a6349777fd992a97d697940e79b2e71dbd1
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2400988
    > > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
    > > Reviewed-by: Georg Neis <neis@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#69812}
    >
    > Bug: v8:7790
    > Change-Id: I459f4bfc881c641258dcc46fc55fce21f9e03dec
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2403921
    > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
    > Commit-Queue: Georg Neis <neis@chromium.org>
    > Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org>
    > Reviewed-by: Georg Neis <neis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#69822}
    
    TBR=neis@chromium.org,solanes@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: v8:7790
    Change-Id: Iec7d708510702a9168c6ad9a7373584f107af739
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2502333Reviewed-by: 's avatarSantiago Aboy Solanes <solanes@chromium.org>
    Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
    Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
    Commit-Queue: Michael Stanton <mvstanton@chromium.org>
    Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70798}
    47ea5fb6
js-heap-broker.cc 203 KB