• Mythri A's avatar
    Reland "[turboprop] Pass required parameters as value inputs to TierUpCheck node" · 71220b3b
    Mythri A authored
    This is a reland of 44f46def with a
    fix for failures with --turbonci_as_mid_tier
    
    Original change's description:
    > [turboprop] Pass required parameters as value inputs to TierUpCheck node
    >
    > TierUpCheck node tail calls interpreter entry trampoline when additional
    > processing is needed for tiering up. Calling IET requires target,
    > new_target, input count and context as parameters. Earlier these were
    > created as parameter nodes in effect-control-linearizer. This causes
    > problems with Turboprop since TurboProp doesn't use the second scheduler
    > and cannot reschedule these nodes to the start block. We should instead
    > create these parameter nodes in bytecode-graph-builder and pass them
    > as value inputs to TierUpCheck node.
    >
    > Bug: v8:9684
    > Change-Id: Icfe5a33b4e628d5a3ba9a3121b2b0746be6aed5c
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2498695
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > Commit-Queue: Mythri Alle <mythria@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#70790}
    
    Bug: v8:9684
    Change-Id: Ic1a7d39aab0a599d0dd421f237e7bc640fcd6eb1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2504258
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70856}
    71220b3b
effect-control-linearizer.cc 239 KB