• Mircea Trofin's avatar
    Revert "Revert "[wasm] Move the ModuleEnv to compiler and make it immutable."" · 72dd5738
    Mircea Trofin authored
    This reverts commit e79d4f06.
    
    Reason for revert: Fixed compile error
    
    Original change's description:
    > Revert "[wasm] Move the ModuleEnv to compiler and make it immutable."
    > 
    > This reverts commit d04660db.
    > 
    > Reason for revert: Suspect for blocking the roll:
    > https://chromium-review.googlesource.com/c/621191
    > 
    > See:
    > https://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/13583
    > 
    > Original change's description:
    > > [wasm] Move the ModuleEnv to compiler and make it immutable.
    > > 
    > > This CL (finally) makes the contract between the compiler and the module
    > > environment clear. In order to compile a function, the caller must provide
    > > an instance of the compiler::ModuleEnv struct, which contains references
    > > to code, function and signature tables, memory start, etc.
    > > 
    > > R=​mtrofin@chromium.org,ahaas@chromium.org
    > > 
    > > Bug: 
    > > Change-Id: I68e44d5da2c5ad44dad402029c2e57f2d5d25b4f
    > > Reviewed-on: https://chromium-review.googlesource.com/613880
    > > Reviewed-by: Mircea Trofin <mtrofin@chromium.org>
    > > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > > Commit-Queue: Ben Titzer <titzer@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#47418}
    > 
    > TBR=titzer@chromium.org,mtrofin@chromium.org,ahaas@chromium.org
    > 
    > Change-Id: I60a369a43121720fbb13ea6c2ec6ca948d60a20b
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Reviewed-on: https://chromium-review.googlesource.com/622547
    > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#47451}
    
    TBR=machenbach@chromium.org,titzer@chromium.org,mtrofin@chromium.org,ahaas@chromium.org
    
    Change-Id: Ie0efa6204c41b2cb672586a7ac0a622ca13ce5fe
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/622033
    Commit-Queue: Mircea Trofin <mtrofin@chromium.org>
    Reviewed-by: 's avatarMircea Trofin <mtrofin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47453}
    72dd5738
function-body-decoder.cc 78 KB