• Seth Brenith's avatar
    Don't rescue old top-level SharedFunctionInfos · 400b2cc2
    Seth Brenith authored
    My previous change https://crrev.com/c/3597106 led to some performance
    regressions in time spent on parsing and compilation. Those regressions
    might be due to increasing the reuse of old top-level
    SharedFunctionInfos. If the top-level SFI is old enough that its
    bytecode can be flushed, then perhaps other SFIs within the script have
    already been flushed. In that case, discarding information from a
    background compilation or code cache deserialization could be harmful.
    
    Bug: v8:12808, chromium:1325566, chromium:1325567, chromium:1325601
    Change-Id: Ia7651bed86eecdbef8878e6132b894ed10163cdc
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3657472
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80697}
    400b2cc2
compilation-cache-table.cc 18.1 KB