• Frank Tang's avatar
    Reland "[Temporal] Fix Calendar.prototype.fields CSA" · 4776aee6
    Frank Tang authored
    This is a reland of commit 89600314
    
    Changes since revert: None, reverted wrong suspect CL
    
    Original change's description:
    > [Temporal] Fix Calendar.prototype.fields CSA
    >
    > Use LoadAndUntagToWord32ObjectField instead of LoadObjectField<Uint32T>
    > to load the flag since it is defined as
    >  flags: SmiTagged<JSTemporalCalendarFlags>;
    >
    > Otherwise LoadObjectField<Uint32T> will load the zero part when
    > v8_enable_pointer_compression = false
    >
    > Add unit tests to intl (because the problem only show up on calendar
    > other than non iso8601.
    >
    > Cq-Include-Trybots: luci.v8.try:v8_linux_mipsel_compile_rel,v8_linux_mips64el_compile_rel
    >
    >
    > Bug: v8:12848
    > Change-Id: I44b685af99dc9820dfa228447e2b42ae0a82464c
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3617388
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Commit-Queue: Frank Tang <ftang@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#80314}
    
    Bug: v8:12848
    Change-Id: I423ea5f0a4a30fc73546df208d24aec84db76eb4
    Cq-Include-Trybots: luci.v8.try:v8_linux_mipsel_compile_rel,v8_linux_mips64el_compile_rel
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3620838
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Commit-Queue: Shu-yu Guo <syg@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80319}
    4776aee6
builtins-temporal-gen.cc 8.21 KB