• Peter Marshall's avatar
    [cpu-profiler] Fix flaky MultipleIsolates test · 8f4c5abf
    Peter Marshall authored
    This test is only flaky because the js code being profiled causes a
    'fast-c-call' which is a call from JS to C without an exit frame.
    
    The profiler stumbles on these and reads the stack of C++ frames when
    it shouldn't, causing ASAN errors. This is not actually related to
    the multiple isolates, so I'm changing the test to profile different
    JS code that does not cause these types of calls. There is already a
    test for fast-c-calls - NativeFrameStackTrace (which currently fails).
    
    Bug: v8:8464
    Change-Id: I32818f0894e5680cf5a39779a2779eda36dfe9f1
    Reviewed-on: https://chromium-review.googlesource.com/c/1337571
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57547}
    8f4c5abf
test-cpu-profiler.cc 90.8 KB