• Nico Hartmann's avatar
    [torque] Enum language feature · fdc9fade
    Nico Hartmann authored
    This CL implements enums in Torque in three steps:
    
    1.) It implements necessary changes to Torque's type system. In
    particular, the constraints on constexpr types are relaxed such that
    constexpr types can exist without a corresponding non-constexpr
    version. Furthermore, constexpr and their non-constexpr counterpart
    need not be of the same kind of type. This allows an AbstractType to
    have a UnionType as its non-constexpr counterpart.
    
    2.) The enum feature itself is realized as a pure desugaring in the
    parser, where all required types, constants and macro specializations
    (like FromConstexpr<>) are generated from a simple enum declaration,
    such that enum entries are not just constants, but are namespace
    scoped and have distinct types so that they can be used within
    typeswitch constructs.
    
    3.) Almost all of the existing constants defined in torque
    (.tq files) are ported to new enum definitions.
    
    Bug: v8:10053
    Change-Id: I72426d3b1434f301fd690847e15603de0dc1021b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1964392
    Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65503}
    fdc9fade
data-view.tq 34.5 KB