• machenbach's avatar
    Revert of Use ES2015-style TypedArray prototype chain (patchset #5 id:80001 of... · 28b55ffd
    machenbach authored
    Revert of Use ES2015-style TypedArray prototype chain (patchset #5 id:80001 of https://codereview.chromium.org/1541233002/ )
    
    Reason for revert:
    [Sheriff] Changes layout tests. Please fix upstream first if intended.
    
    https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3689
    
    Original issue's description:
    > Use ES2015-style TypedArray prototype chain
    >
    > This patch switches TypedArrays to use the prototype chain described
    > in the ES2015 specification, which adds a %TypedArray% superclass above
    > all individual TypedArray types. Most methods are defined on the
    > superclass rather than the subclasses.
    >
    > In order to prevent a performance regression, a few methods are
    > marked as inline. Inlining might prevent code which was previously
    > monomorphic from becoming polymorphic, and it was specifically
    > applied in places where methods became more polymorphic than before.
    > Tests with realistic workloads would be nice to do before this
    > ships in stable.
    >
    > This patch does not bring TypedArrays up to full spec compliance. In
    > particular, @@species is not yet supported.
    >
    > R=cbruni
    > BUG=v8:4085
    > LOG=Y
    >
    > Committed: https://crrev.com/07c91dccbe55c7be3ec75857dee5ad59873330b7
    > Cr-Commit-Position: refs/heads/master@{#33050}
    
    TBR=caitpotter88@gmail.com,cbruni@chromium.org,littledan@chromium.org
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=v8:4085
    
    Review URL: https://codereview.chromium.org/1554523002
    
    Cr-Commit-Position: refs/heads/master@{#33053}
    28b55ffd
messages.h 37.1 KB