• ishell's avatar
    [api] Make ObjectTemplate::SetNativeDataProperty() work even if the... · 6a118774
    ishell authored
    [api] Make ObjectTemplate::SetNativeDataProperty() work even if the ObjectTemplate does not have a constructor.
    
    Previously ObjectTemplate::New() logic relied on the fact that all the accessor properties are already installed in the initial map of the function object of the constructor FunctionTemplate.
    When the FunctionTemplate were instantiated the accessors of the instance templates from the whole inheritance chain were accumulated and added to the initial map.
    ObjectTemplate::SetSetAccessor() used to explicitly ensure that the ObjectTemplate has a constructor and therefore an initial map to add all accessors to.
    
    The new approach is to add all the accessors and data properties to the object exactly when the ObjectTemplate is instantiated. In order to keep it fast we now cache the object boilerplates in the Isolate::template_instantiations_cache (the former function_cache), so the object creation turns to be a deep copying of the boilerplate object.
    
    This CL also prohibits non-primitive properties in ObjectTemplate to avoid potential cross-context leaks.
    
    BUG=chromium:579009
    LOG=Y
    
    Review URL: https://codereview.chromium.org/1642223003
    
    Cr-Commit-Position: refs/heads/master@{#33674}
    6a118774
contexts.h 31 KB