• Jakob Gruber's avatar
    [regexp] Limit the size of inlined choice nodes · 6a0e7224
    Jakob Gruber authored
    Codegen for unicode property escapes (e.g.: /\p{L}/u) can produce huge
    code objects. This effect can be further magnified through inlining,
    leading to exponential code growth in the size of the pattern.
    
    This CL is a (fairly hacky) way to avoid exponential growth. We
    recognize choice nodes with 'many' choices and disable inlining for
    them. In the future we should fix this properly, either by using the
    code size budget correctly, or by improving codegen for property
    escapes.
    
    Bug: v8:10441
    Change-Id: I817f145251ec8b1b9906cc735c9e9bdb004c98ed
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2170229
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67433}
    6a0e7224
test-regexp.cc 85.3 KB