• Benedikt Meurer's avatar
    [inspector] Gracefully ignore non-dictionary values as session state. · dc3eb449
    Benedikt Meurer authored
    The V8InspectorSessionImpl constructor accepts a state, as either text
    or CBOR encoded, and generally ignores all invalid inputs, except for
    the case where it's a valid value, but not a dictionary value, in which
    case it'll leak the value and crash upon casting to a `DictionaryValue`.
    
    This is purely an issue with the test driver, so no security impact on
    Chromium in the wild.
    
    Fixed: chromium:1281031
    Change-Id: I7b4d0aea83370499b1274d3fa214a14dc098d2f2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3361838
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78490}
    dc3eb449
v8-inspector-session-impl.cc 19.9 KB