• Adam Klein's avatar
    Revert "[osr] Basic support for concurrent OSR" · 32f28553
    Adam Klein authored
    This reverts commit 3ce690ee.
    
    Reason for revert: failures on CrOS MSan build: https://crbug.com/1312188
    
    Original change's description:
    > [osr] Basic support for concurrent OSR
    >
    > This CL adds basic support behind --concurrent-osr,
    > disabled by default.
    >
    > When enabled:
    > 1) the first OSR request starts a concurrent OSR compile job.
    > 2) on completion, the code object is inserted into the OSR cache.
    > 3) the next OSR request picks up the cached code (assuming the request
    >    came from the same JumpLoop bytecode).
    >
    > We add a new osr optimization marker on the feedback vector to
    > track whether an OSR compile is currently in progress.
    >
    > One fundamental issue remains: step 3) above is not guaranteed to
    > hit the same JumpLoop, and a mismatch means the OSR'd code cannot
    > be installed. This will be addressed in a followup by targeting
    > specific bytecode offsets for the install request.
    >
    > This change is based on fanchen.kong@intel.com's earlier
    > change crrev.com/c/3369361, thank you!
    >
    > Bug: v8:12161
    > Change-Id: Ib162906dd4b6ba056f62870aea2990f1369df235
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3548820
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Commit-Queue: Jakob Linke <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#79685}
    
    Bug: v8:12161, chromium:1312188
    Change-Id: Iac1e3fd67ecc658a1cdee8f4d13354c097ed6697
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3564983
    Auto-Submit: Adam Klein <adamk@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79702}
    32f28553
feedback-vector.tq 1.29 KB