• Benedikt Meurer's avatar
    [inspector] Add internal property to identify detached ArrayBuffers. · b886e153
    Benedikt Meurer authored
    This adds an internal property [[IsDetached]] to the inspector preview
    of ArrayBuffer instances, which indicates whether the ArrayBuffer was
    detached (i.e. transfered via `postMessage`). Previously it was rather
    impossible to tell whether an ArrayBuffer was detached, you had to know
    that V8 violates the ECMAScript specification and simply sets the
    byteLength accessor to 0 upon detaching an ArrayBuffer (but even then it
    was still impossible to tell whether that ArrayBuffer wasn't simply an
    empty one from the get go).
    
    Before: https://imgur.com/UcOF83c
    After: https://imgur.com/WjmTehZ
    
    Fixed: chromium:1109102
    Change-Id: I8fb6e2be2fbfe5c62b05dc9d2a0f18378eb4de6c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316075
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69034}
    b886e153
get-properties-paused-expected.txt 2.29 KB