• Seth Brenith's avatar
    [heap] Don't age bytecode when GCing for devtools snapshot · 4b532343
    Seth Brenith authored
    When preparing to take a heap snapshot for the devtools, V8 uses
    CollectAllAvailableGarbage, which runs 2 to 7 rounds of garbage
    collection, depending on whether weak callbacks indicate that further
    rounds might be beneficial. Depending on how many rounds of GC run,
    varying amounts of bytecode and baseline code may be flushed, leading to
    inconsistent behavior and underreporting the amount of memory used by
    bytecode and baseline code. In this change, I propose that bytecode
    should not increase in age during these collections, so that the
    resulting snapshot is a better indication of actual memory usage.
    
    Change-Id: I644be37833f85bb58e2e2fad5da62949cbdc9bef
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182885Reviewed-by: 's avatarDominik Inführ <dinfuehr@chromium.org>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/main@{#77122}
    4b532343
heap.cc 258 KB