• Toon Verwaest's avatar
    Reland^3 "[runtime] Amortize descriptor array growing for fast-mode prototypes" · 65630850
    Toon Verwaest authored
    This CL:
     - stops tracking transitions for fast maps that are known to be detached
     - reuses descriptor arrays when transitioning detached maps to avoid O(n^2) performance and garbage creation
    
    Fix in reland: check whether the map of the back pointer is the metamap rather than reading the map of the constructor-or-backpointer slot. If the slot contains a constructor, it's possible that the object transitions while the concurrent marker is reading the map (from which it's reading the instance type); and it's possible that the transitioned map isn't set up yet fully when we read the instance type. An acquire load for the constructor-or-backpointer map would also fix it by serializing stores, but is more expensive. Checking the metamap is faster.
    
    Original commit message:
    > This avoids an O(n^2) algorithm that creates an equal amount of garbage.
    > Even though the actual final descriptor array might be a little bigger,
    > it reduces peak memory usage by allocating less.
    
    TBR=ulan@chromium.org,ishell@chromium.org
    
    Change-Id: I57000949debdee2b69dd41e0c5975b3e8a34c6f4
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: b:148346655, v8:10339
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2173363
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67499}
    65630850
map.h 47.1 KB