• Milad Farazmand's avatar
    Revert "PPC/s390: Reland: [builtins] Move non-JS linkage builtins code objects into RO_SPACE" · 32b2d32c
    Milad Farazmand authored
    This reverts commit 94456e5c.
    
    Reason for revert: <INSERT REASONING HERE>
    
    Original change's description:
    > PPC/s390: Reland: [builtins] Move non-JS linkage builtins code objects into RO_SPACE
    > 
    > Port 855591a5
    > 
    > Original Commit Message:
    > 
    >     Reland of https://chromium-review.googlesource.com/c/v8/v8/+/1795358.
    > 
    >     [builtins] Move non-JS linkage builtins code objects into RO_SPACE
    > 
    >     Creates an allow-list of builtins that can still go in code_space
    >     including all TFJ builtins and a small manual list that should be pared
    >     down in the future.
    > 
    >     For builtins that go in RO_SPACE a Code object is created that contains an
    >     immediate trap instruction. Generally these Code objects are still no
    >     smaller than CODE_SPACE Code objects because of the Code object alignment
    >     requirements. This will hopefully be addressed in a follow-up CL either by
    >     relaxing them or removing the instruction stream completely.
    > 
    >     In the snapshot, this reduces code_space from ~152k to ~40k (-112k) and
    >     increases by the same amount.
    > 
    > R=​delphick@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
    > BUG=
    > LOG=N
    > 
    > Change-Id: Ibd0713a17df9c873692553f2d57f4ba36bcdb342
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1893746
    > Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
    > Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
    > Cr-Commit-Position: refs/heads/master@{#64704}
    
    TBR=michael_dawson@ca.ibm.com,jyan@ca.ibm.com,joransiu@ca.ibm.com,delphick@chromium.org,miladfar@ca.ibm.com
    
    Change-Id: I808a4220892dcfef66b4b9d90ab43bf403d2e9b0
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1894353Reviewed-by: 's avatarMilad Farazmand <miladfar@ca.ibm.com>
    Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
    Cr-Commit-Position: refs/heads/master@{#64705}
    32b2d32c
macro-assembler-ppc.h 40.1 KB