• Georgia Kouveli's avatar
    [arm64][cfi] Skip authenticating return addresses in the profiler · bf383a87
    Georgia Kouveli authored
    The SafeStackFrameIterator, used in the profiler, sometimes uses the
    link register instead of a return address stored on the stack, to get
    more accurate results. This happens in particular for bytecode handlers
    that do not create a stack frame. Authentication of PC for those frames
    would fail in the SafeStackFrameIterator, as the "PC address" would not
    point to a stack location with a signed return address, but instead to
    a member of the SafeStackFrameIterator class where the value of the link
    register was stored. We address this by skipping authentication of PCs
    in the profiler.
    
    Bug: v8:10026
    Change-Id: I331c6c68e703db766be1891efffa69c2f9794e8a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2242954Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com>
    Cr-Commit-Position: refs/heads/master@{#68388}
    bf383a87
tick-sample.cc 14.3 KB