• Simon Zünd's avatar
    [torque] Add lint errors for unused variable and label bindings · 0e53739c
    Simon Zünd authored
    This CL adds lint errors when 'let' bindings, arguments and labels
    are not used. Note that errors for 'const' bindings will be added
    later.
    
    In cases where arguments are actually needed to match the signature,
    the warning can be silenced by prefixing identifiers with "_". This
    might be needed for generic specializations or builtins called from
    TurboFan. Trying to use a variable or label that was marked with
    "_" results in a compilation error.
    
    Implicit arguments are not linted. They are implemented using exact
    string matching. Prefixing an implicit argument with "_" in a callee
    would break all callers as the names would no longer match.
    
    Drive-by: Fix all new lint errors in the existing Torque code.
    
    Bug: v8:7793
    Change-Id: I68b3c59c76b956e9f88709e9388a40a19546ce52
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645092
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62027}
    0e53739c
torque-parser.cc 72.7 KB