• Clemens Backes's avatar
    [wasm][debug] Prefer debug code in tiered down mode · cf382c89
    Clemens Backes authored
    We were still occasionally failing tests because sometimes non-debug
    Liftoff code was published *after* debug Liftoff code. This would
    overwrite the debug code and we would not stop on function entry then.
    This fixes this by only preferring Liftoff code in publishing if it has
    been compiled for debugging.
    As a side effect, this will also prefer TurboFan code which has been
    compiled for debugging (i.e. Liftoff bailed out), but this would only
    happen for experimental features and in this case we will just overwrite
    TurboFan code with TurboFan code, which is fine.
    
    R=thibaudm@chromium.org
    
    Bug: v8:10410
    Change-Id: I6516e9f474f6118f0f0c077e6789f604ca128e74
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144122Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67123}
    cf382c89
wasm-code-manager.cc 79.8 KB