• mythria's avatar
    [Interpreter] Fixes PushArgsAndConstruct builtin to not store any data outside esp. · dbf5fffd
    mythria authored
    In ia32 PushArgsAndConstruct builtin, we run out of registers and need to
    temporarily store the data in the stack. In the earlier implementation,
    a location outside the esp was used. This causes a problem if there is a
    interrupt/signals which would use the same stack and corrupt the data that
    is above the esp. This cl fixes it by pushing it onto the stack so that
    the stack pointer is updated and hence the corruption will not happen. We
    reuse the slot meant for receiver as a temporary store.
    
    TBR=rmcilroy@chromium.org
    BUG=v8:4280
    LOG=N
    
    Review URL: https://codereview.chromium.org/1750373002
    
    Cr-Commit-Position: refs/heads/master@{#34397}
    dbf5fffd
builtins-ia32.cc 91.7 KB