• Jakob Gruber's avatar
    [compiler] Consider IsPendingAllocation in Ref construction · 5f0ac36c
    Jakob Gruber authored
    The logic in JSHeapBroker::TryGetOrCreateData assumes that parts
    of the object are safe to read. In particular, the instance type
    must be readable for the chain of `Is##Name()` type checks.
    
    This is guaranteed if
    
     - a global memory fence happened after object initialization and
       prior to the read by the compiler; or
     - the object was published through a release store and read through
       an acquire read.
    
    The former is protected by the new call to ObjectMayBeUninitialized
    (which internally calls IsPendingAllocation) in TryGetOrCreateData.
    
    The latter must be marked explicitly by calling the new
    MakeRefAssumeMemoryFence variant.
    
    Note that support in this CL is expected to be incomplete and will
    have to be extended in the future as more cases show up in which
    MakeRef calls must be converted to MakeRefAssumeMemoryFence or to
    TryMakeRef.
    
    Bug: v8:7790,v8:11711
    Change-Id: Ic2f7d9fc46e4bfc3f6bbe42816f73fc5ec174337
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874663
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74474}
    5f0ac36c
js-heap-broker.cc 44.3 KB