• Samuel Groß's avatar
    Revert "Reland "[sandbox] Sandboxify EmbedderDataSlots"" · a9dcb35e
    Samuel Groß authored
    This reverts commit eca383c9.
    
    Reason for revert: Still seeing DCHECK failures in SweepAndCompact
    
    Original change's description:
    > Reland "[sandbox] Sandboxify EmbedderDataSlots"
    >
    > This is a reland of commit e1f585ed
    >
    > ExternalPointerTable issues have been fixed in
    > https://crrev.com/c/3849650 and https://crrev.com/c/3849376
    >
    > Original change's description:
    > > [sandbox] Sandboxify EmbedderDataSlots
    > >
    > > Bug: v8:10391
    > > Change-Id: If85a308a6f6ed1b17d86f87b4911c82d2327ea72
    > > Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3757341
    > > Reviewed-by: Igor Sheludko <ishell@chromium.org>
    > > Commit-Queue: Samuel Groß <saelo@chromium.org>
    > > Cr-Commit-Position: refs/heads/main@{#82623}
    >
    > Bug: v8:10391
    > Change-Id: If77f6c10e81c30c2dfa6b33c788bc4a36e4da135
    > Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3852602
    > Commit-Queue: Samuel Groß <saelo@chromium.org>
    > Reviewed-by: Igor Sheludko <ishell@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#82686}
    
    Bug: v8:10391
    Change-Id: Icaa1ff64cabd1bb2f19d9b019eac0ca98e528eb6
    Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3854677Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82698}
    a9dcb35e
v8-internal.h 36.2 KB