• littledan's avatar
    Filter out synthetic variables from with scopes · dcd61b90
    littledan authored
    This patch ensures that variables like .new_target aren't overwritable
    using with scopes. It does this by ensuring that scope analysis does
    not consider with scopes (or eval scopes) for such 'synthetic variables',
    similarly to how the 'this' variable was already handled.
    The patch also adds a DCHECK for the dynamic parallel to this case,
    replacing a previous unreachable path for a particular instance.
    
    BUG=v8:5405
    
    Review-Url: https://codereview.chromium.org/2353623002
    Cr-Commit-Position: refs/heads/master@{#39567}
    dcd61b90
contexts.cc 20.2 KB