• Shu-yu Guo's avatar
    Fix parking of outer Isolate during snapshot stress · 5ae6ca08
    Shu-yu Guo authored
    Turns out parking the outer Isolate needs to encompass the entire
    lifetime of the inner Isolate during snapshot stress. Isolate
    initialization locks the shared Isolate's client mutex to prevent shared
    GCs. This mutex is also taken on Heap teardown on Isolate shutdown
    during the shared heap verification, which may end up waiting in a
    safepoint, causing deadlock.
    
    Bug: v8:13217
    Change-Id: I3893ae883ab345a9d36c9437ea15e90f18951057
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3843288Reviewed-by: 's avatarJakob Linke <jgruber@chromium.org>
    Commit-Queue: Jakob Linke <jgruber@chromium.org>
    Auto-Submit: Shu-yu Guo <syg@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82607}
    5ae6ca08
snapshot.cc 30.2 KB