• Yang Guo's avatar
    Make termination exception more consistent. · 7e5cac2c
    Yang Guo authored
    Termination exceptions tear down V8 to the bottom-most V8 call. If there is a
    v8::TryCatch scope around that call, it returns true for HasTerminated() and
    HasCaught(). However, Isolate::IsExecutionTerminating() returns false and we
    can call into V8 from still inside the v8::TryCatch scope.
    
    Changes that this patch introduces:
     - You need to leave the v8::TryCatch scope around the bottom-most call to
       reset the termination state, in order to resume.
     - Explicitly check for termination exception and reporting it through the
       DevTools protocol after Runtime.evaluate and Debugger.evaluateOnCallFrame.
    
    Bug: v8:8455
    Change-Id: I1f36f7a365985469813c2619bf16f18ee69aa4b8
    Reviewed-on: https://chromium-review.googlesource.com/c/1337582Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57963}
    7e5cac2c
api.cc 396 KB