• Jakob Kummerow's avatar
    Revert "Fix ArrayConcat length estimation for TypedArrays" · 5785e0b7
    Jakob Kummerow authored
    This reverts commit 5f8e95c1.
    
    Reason for revert: crbug.com/1033418. TypedArrays are not, by default, concat-spreadable; the existing code is inconsistent and this CL didn't update/fix enough of it.
    
    Original change's description:
    > Fix ArrayConcat length estimation for TypedArrays
    >
    > TypedArrays cannot be handled on the JSArray path.
    > This patch should provide a minor performance improvement while
    > being functionally non-observable.
    >
    > Change-Id: I05259517b9079aa715b3cf4be9b0cf6bb47236ac
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948712
    > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    > Reviewed-by: Igor Sheludko <ishell@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#65419}
    
    TBR=jkummerow@chromium.org,ishell@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: chromium:1033418
    Change-Id: I345c8ebc38be6df42d5bdbecd0d06d19967ad6f1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967324
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65447}
    5785e0b7
builtins-array.cc 54.7 KB