• Benedikt Meurer's avatar
    [inspector] Set limit for Wasm wire byte transfer via CDP. · 7842920a
    Benedikt Meurer authored
    The `Debugger.getScriptSource()` and `Debugger.getWasmBytecode()`
    methods in the CDP return Wasm wire bytes as protocol::Binary, which is
    send as Base64-encoded JSON string in the communication to the DevTools
    front-end, and hence leads to either crashing the renderer that is being
    debugged or the renderer that's running the front-end if we allow
    arbitrarily huge Wasm byte sequences here. This CL introduces a limit,
    based on the maximum allowed string length, to avoid the crash and
    instead signal a proper error to the DevTools front-end.
    
    Bug: chromium:1099680
    Change-Id: I356d617301d17a4012f7f845773cf14e6ad1e4a7
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270174
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68560}
    7842920a
v8-debugger-agent-impl.cc 73.5 KB