• Kim-Anh Tran's avatar
    [debug] Capture more cases for instrumentation breakpoints · 0c3fdff2
    Kim-Anh Tran authored
    The previous implementation would not explicitly send
    `Debugger.paused` events for instrumentation breakpoints
    if they were to overlap with breaks due to:
    * regular breakpoints
    * OOM
    * exceptions
    * asserts
    
    This CL is a step towards making sure that a separate
    `Debugger.paused` event is always sent for an instrumentation
    breakpoint. In some cases where we have overlapping reasons
    but only know of one, the 'instrumentation' reason,
    we still just send out one paused event with the reason
    being `instrumentation`.
    
    Drive-by: send instrumentation notification to all sessions,
    remember which breakpoints are instrumentation breakpoints
    
    Bug: chromium:1229541, chromium:1133307
    Change-Id: Ie15438f78b8b81a89c64fa291ce7ecc36ebb2182
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211892Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77333}
    0c3fdff2
set-instrumentation-breakpoint-expected.txt 2.1 KB