• Eric Holk's avatar
    Revert "[wasm] Add guard pages before Wasm Memory" · 54be464f
    Eric Holk authored
    This reverts commit d7cdea6f.
    
    Reason for revert: Flakiness on bots
    
    Original change's description:
    > [wasm] Add guard pages before Wasm Memory
    > 
    > Although Wasm memory indices are all unsigned, they sometimes get assembled
    > as 32-bit signed immediates. Values in the top half of the Wasm memory space
    > will then get sign extended, causing Wasm to access in front of its memory
    > buffer.
    > 
    > Usually this region is not mapped anyway, so faults still happen as they are
    > supposed to. This change protects this region with guard pages so we are
    > guaranteed to always fault when this happens.
    > 
    > Bug: v8:5277
    > Change-Id: Id791fbe2a5ac1b1d75460e65c72b5b9db2a47ee7
    > Reviewed-on: https://chromium-review.googlesource.com/484747
    > Commit-Queue: Eric Holk <eholk@chromium.org>
    > Reviewed-by: Mircea Trofin <mtrofin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#44905}
    
    TBR=bradnelson@chromium.org,gdeepti@chromium.org,mtrofin@chromium.org,eholk@chromium.org,mseaborn@chromium.org,adamk@chromium.org,v8-reviews@googlegroups.com,wasm-v8@google.com
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    
    Change-Id: Ia1d3e5dbf4f518815a9fd4197047077bc8e42816
    Reviewed-on: https://chromium-review.googlesource.com/487828Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#44907}
    54be464f
wasm-module.cc 137 KB