• machenbach's avatar
    Revert of [turbofan] Introduce CheckUnless. (patchset #1 id:1 of... · 46c21b2c
    machenbach authored
    Revert of [turbofan] Introduce CheckUnless. (patchset #1 id:1 of https://codereview.chromium.org/2080113002/ )
    
    Reason for revert:
    [Sheriff] Speculative revert: Seems to lead to devtools crashes:
    https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/5259
    
    Original issue's description:
    > [turbofan] Introduce CheckUnless.
    >
    > Similarly to CheckIf, CheckUnless is a deoptimization without a specific
    > frame state. A frame state is assigned during effect-control linearization
    > (and CheckUnless is turned into DeoptimizeUnless).
    >
    > At the moment, the new operator is only used at one place in native context
    > specialization, but we should use it everywhere. The advantage of
    > CHeckUnless is that it avoids non-truncating uses of values by frame
    > states. This particular change is aimed at Octane's crypto, where this
    > enables to turn one NumberMultiply into Int32Mul, and thus improve
    > the score by more than 10% (it also needs minus zero truncation and
    > typing to be improved, but those CLs are already in flight).
    >
    > BUG=v8:4470
    > R=bmeurer@chromium.org
    >
    > Committed: https://crrev.com/85fde59d538e0dcaf461108086c2f7cf904f567a
    > Cr-Commit-Position: refs/heads/master@{#37085}
    
    TBR=bmeurer@chromium.org,jarin@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=v8:4470
    
    Review-Url: https://codereview.chromium.org/2078333002
    Cr-Commit-Position: refs/heads/master@{#37090}
    46c21b2c
effect-control-linearizer.cc 62 KB