• Peter Kasting's avatar
    Fix some instances of -Wunreachable-code-aggressive. · ca596361
    Peter Kasting authored
    These need some consideration.  Clang apparently considers V8_UNLIKELY
    to mean "always false", which seems questionable to me (possibly a
    bug?).  That said, removing it in the cases here doesn't seem likely to
    cause problems -- the logging instance seems fine, and the other used to
    not have the macro and gained it in a commit that seemed to have nothing
    to do with performance.
    
    The trampoline register change is safe, but perhaps V8 will support an
    architecture in the future which needs this conditional?
    
    I'd leave these as-is, but it also seems a shame not to enable
    -Wunreachable-code-aggressive just because of these...
    
    Bug: chromium:1066980
    Change-Id: Ib819298cecba082666c26fa7010009f8e9441bf8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2994805
    Auto-Submit: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Hannes Payer <hpayer@chromium.org>
    Reviewed-by: 's avatarHannes Payer <hpayer@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75681}
    ca596361
embedded-data.cc 18.7 KB