• Clemens Hammacher's avatar
    Revert "[wasm] Add more unit tests for trap handler" · 2fd07376
    Clemens Hammacher authored
    This reverts commit 4644b32e.
    
    Reason for revert: Link errors on win64: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20debug/25950
    
    Original change's description:
    > [wasm] Add more unit tests for trap handler
    > 
    > The unittests test if the trap handler only handles those traps it
    > is supposed to handle:
    > * Only handle traps when the thread-in-wasm flag is set.
    > * Only handle traps of the right type, i.e. memory access violations.
    > * Only handle traps at recorded instructions.
    > 
    > The tests also test the consistency of the thread-in-wasm flag. I made
    > one change in the trap handler where that consistency could be
    > violated.
    > 
    > All tests are executed with the default trap handler provided by V8,
    > and with the trap handler callback installed in a test signal/exception
    > handler.
    > 
    > Change-Id: I03904bb6effd2e8694d3f4d1fbf62bc38002646e
    > Reviewed-on: https://chromium-review.googlesource.com/c/1340246
    > Commit-Queue: Andreas Haas <ahaas@chromium.org>
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#57858}
    
    TBR=mstarzinger@chromium.org,ahaas@chromium.org,mark@chromium.org
    
    Change-Id: Iac2f20c73744226885ea1810813863a21c5faf8c
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/1351021Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57861}
    2fd07376
handler-inside-posix.cc 5.07 KB