• Victor Gomes's avatar
    [tests] Fix parameter indices in test-code-stub-assembler · ebcc39d5
    Victor Gomes authored
    The cctests were wrong, since they access the first parameter using `Parameter(0)`. They should instead use `Parameter(1)`, since the index 0 is the receiver, and the receiver is set to be always the undefined object in `FunctionTester::Call`.
    
    The reason it used to work is that the tests would set up an access to the stack with the wrong number of parameters, accessing only a stack suffix.
    
    Change-Id: I02b7ee97c8759c7aecda0338863b7727762df1ba
    Bug: v8:10201
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2299364
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Auto-Submit: Victor Gomes <victorgomes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68876}
    ebcc39d5
test-code-stub-assembler.cc 143 KB