• Rob Paveza's avatar
    SHA256 hash crash: GetScriptHash · c4d09aef
    Rob Paveza authored
    Initialization after reset + unnecessary use of handle scope appear to
    be the culprit here. Most of the other functions in debug::Script do not
    use HandleScope, so this reconciles these differences. Additionally,
    the call to obtain and initialize the hash within
    ActualScript::Initialize was inconsistent: all of the other fields were
    initialized prior to resetting the script and source.
    
    These reconciliations appear to fix this crash.
    
    Bug: chromium:1325036
    Change-Id: Ia86e83b6c99955a3ac80a4a8845c0df0172e991c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3648082
    Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com>
    Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Auto-Submit: Robert Paveza <Rob.Paveza@microsoft.com>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80760}
    c4d09aef
v8-debugger-script.cc 12.1 KB