• Iain Ireland's avatar
    [regexp] Add syntax_only option to ParseRegExp · 5058c397
    Iain Ireland authored
    To ensure that regexp syntax errors are reported as early errors, SpiderMonkey calls ParseRegExp at parse time to validate that the regexp parses properly. This does not require the allocation of named capture information. We have a project underway to completely eliminate the allocation of GC things at parse time, which will require us to suppress the allocation of named capture information (or else jump through hoops to implement FixedArray as a non-GC thing).
    
    We can work around this in our shim layer -- for example, by setting a flag on the Factory shim that causes us to allocate dummy objects -- but it's much simpler to add an option to ParseRegExp.
    
    (Note: V8 currently does not treat regexp syntax errors as early errors. See https://bugs.chromium.org/p/v8/issues/detail?id=896.)
    
    Bug: v8:10406
    Change-Id: Ib5f0613a54509146e00f90cf61bda4bf03b03859
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207813
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67995}
    5058c397
regexp-parser.h 12.9 KB