• Andreas Haas's avatar
    [wasm] Abort AsyncCompileJobs when a Chrome tab refreshes · 9f7fb728
    Andreas Haas authored
    When a tab in Chrome gets refreshed, the refreshed page reuses the
    isolate of the original page. This means that at the moment,
    AsyncCompileJobs which were stared on the original page do not get
    aborted and will therefore eventually finish and resolve their promise.
    With this CL I abort all running AsyncCompileJobs when V8 gets the tab
    refresh signal, i.e. Isolate::ContextDisposedNotification. Note that I
    cannot just call CompilationManager::TearDown because it assumes that
    there are no pending tasks anymore.
    
    R=clemensh@chromium.org, hpayer@chromium.org
    
    Bug: chromium:803476
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    Change-Id: I88d28fdaba6f55b7aa7379c4b5338ae62134fc8a
    Reviewed-on: https://chromium-review.googlesource.com/875923
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarHannes Payer <hpayer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50765}
    9f7fb728
compilation-manager.h 2.1 KB