• Jakob Gruber's avatar
    Revert "[builtins] Embed builtins into the binary" · 4f18484b
    Jakob Gruber authored
    This reverts commit 491d5a81.
    
    Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Mac64/builds/20696
    
    Original change's description:
    > [builtins] Embed builtins into the binary
    > 
    > This embeds code for off-heap-safe builtins into the binary. Actual
    > execution of embedded code is not implemented yet.
    > 
    > The embedded file has the following format:
    > 
    > namespace v8 {
    > namespace internal {
    > 
    > namespace {
    > 
    > V8_EMBEDDED_TEXT_HEADER(v8_embedded_blob_)
    > __asm__( /* builtin offsets and lengths */ );
    > __asm__(V8_ASM_LABEL("Builtins_RecordWrite"));
    > __asm__( /* binary instruction stream */ );
    > /* Repeat for other builtins. */
    > 
    > extern "C" const uint8_t v8_embedded_blob_[];
    > static const uint32_t v8_embedded_blob_size_ = /* size in bytes */;
    > 
    > }  // namespace
    > 
    > const uint8_t* DefaultEmbeddedBlob() { return v8_embedded_blob_; }
    > uint32_t DefaultEmbeddedBlobSize() { return v8_embedded_blob_size_; }
    > 
    > }  // namespace internal
    > }  // namespace v8
    > 
    > Bug: v8:6666
    > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux64_fyi_rel_ng
    > Change-Id: Ic989f01da69ebe2863f31d934bfbe2c5d6e80864
    > Reviewed-on: https://chromium-review.googlesource.com/946011
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#51759}
    
    TBR=yangguo@chromium.org,jgruber@chromium.org
    
    Change-Id: I36f5ee173fca565327b7f3e0ea20503ceef451fe
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:6666
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux64_fyi_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/950982Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51760}
    4f18484b
snapshot-common.cc 16.6 KB