• Benedikt Meurer's avatar
    [inspector] Decouple Console domain from stack trace capturing. · 451a101b
    Benedikt Meurer authored
    The `Console` domain has been deprecated (in favor of `Log` and
    `Runtime`) since over four years now, and its use is strongly
    discouraged.
    
    However, making `Runtime.setMaxCallStackSizeToCapture` useful (in
    light of the refactorings for crbug.com/1283162) and more correct
    (wrt. to the anticipated behavior), would be complicated seriously
    if we also need to worry about `Console` domain interference.
    
    So this CL simply removes the feature that `Console.enable` turns
    on stack trace capturing for error and message objects, and won't
    send `line`, `column`, and `url` with `Console.Message` events
    if they aren't present on the `v8_inspector::V8ConsoleMessage`
    instance (these fields have always been optional anyways).
    
    Bug: chromium:1283162
    Change-Id: I78bd1e040fe15a2372639c403bfc2f4579fd4d0c
    Doc: https://bit.ly/v8-cheaper-inspector-stack-traces
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3361837
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78454}
    451a101b
v8-console-agent-impl.cc 2.43 KB