• Yang Guo's avatar
    Allow name collision when materializing scope object · 5395045f
    Yang Guo authored
    When materializing a scope object, we previously assumed that we will
    not have any name collisions. This is not correct e.g. when eval
    introduces an aliased local variable.
    
    This CL resolves this wrong assumption. The test case should not crash.
    It however fails as there is a bug in how debug-evaluate should resolve
    variables defined in eval.
    
    R=verwaest@chromium.org
    
    Fixed: chromium:1240962
    Bug: chromium:1264852
    Change-Id: I0e41e7905589735e25eff221376d09997ea99117
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3250911
    Auto-Submit: Yang Guo <yangguo@chromium.org>
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77649}
    5395045f
factory.cc 152 KB