• machenbach's avatar
    Revert of [wasm] Indirect calls without function table cause validation... · 32ec567d
    machenbach authored
    Revert of [wasm] Indirect calls without function table cause validation errors. (patchset #3 id:40001 of https://codereview.chromium.org/2484623002/ )
    
    Reason for revert:
    Speculative revert for blocking roll:
    https://codereview.chromium.org/2479233002/
    
    Original issue's description:
    > [wasm] Indirect calls without function table cause validation errors.
    >
    > The spec defines that indirect calls in WebAssembly code should cause a
    > validation error if no function table exists.
    >
    > The CL contains the following changes:
    > 1) Throw a validation error for indirect calls if the function table
    >    not exist.
    > 2) Do not create TF nodes to throw a runtime error for indirect calls
    >    if the function table does not exist.
    > 3) Fix existing unit tests by creating a dummy function table.
    > 4) Add new a new test which tests that indirect calls without function
    >    table cause a validation error.
    >
    > R=rossberg@chromium.org
    > CC=titzer@chromium.org
    >
    > TEST=unittests/AstDecoderTest.IndirectCallsWithoutTableCrash
    
    TBR=rossberg@chromium.org,titzer@chromium.org,ahaas@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    
    Review-Url: https://codereview.chromium.org/2479283002
    Cr-Commit-Position: refs/heads/master@{#40811}
    32ec567d
ast-decoder.cc 65.1 KB