• Omer Katz's avatar
    cppgc: Mark in construction objects externally · cebd8b65
    Omer Katz authored
    In construction objects don't have anything to sync with on the
    allocation side since they weren't marked as fully constructed yet.
    This could mean the initialization of the marking bit on the mutator
    thread and setting the mark bit on a concurrent thread could race
    (potentially resulting in losing the mark bit when the gc info index
    overwrites it).
    
    This CL fixes this issue by using a set of in construction objects.
    In construction objects are no longer marked. Instead they are pushed
    to the set and the heap object header is marked when they are popped
    from the worklist. Since the set avoids duplicates, this allows us to
    both avoid worklist explosion (due to pushing the same in construction
     object multiple times) and avoid the data race on the mark bit.
    
    This CL uses an unordered_set to record objects. Synchronization uses
    a lock, which could be costly but is not expected to be obtained often.
    
    Bug: chromium:1056170
    Change-Id: I366b59f476c166ff06e15b280df9e846034cc6cf
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2437388
    Commit-Queue: Omer Katz <omerkatz@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70282}
    cebd8b65
marking-visitor-unittest.cc 9.78 KB